Display download progress for file downloads #2327
Conversation
legoktm
force-pushed
the
download-progress
branch
from
41d1174 to
ec75f0b
Compare
|
So right now I've implemented an exponential moving average based on https://stackoverflow.com/questions/2779600/how-to-estimate-download-time-remaining-accurately; however I missed the comment which says, "EMA will only work if the time-sampling rate is about the same. If, for example the download is updated every 1 MB rather than every 1 second and the speed fluctuates the output will most likely be nonsense". Unfortunately that's exactly what we're doing, we update on chunks rather than on a regular time interval. Will require some more 🤔 |
legoktm
force-pushed
the
download-progress
branch
2 times, most recently
from
cb0c67f to
1571296
Compare
|
I got a smoothed version of the download speed to work (by adjusting the SMOOTHING_FACTOR to be relative to the time period), but there's a more practical problem: we only update the speed after we receive a chunk, so if it stalls, we don't update the speed and it'll get stuck at e.g. 4MB/s. So I want to rework this a bit, I'll move the calculation stuff into the widget and we can use a QTimer to update the widget's speed on an actual time interval. |
legoktm
force-pushed
the
download-progress
branch
3 times, most recently
from
a8222ca to
6ae75e9
Compare
Display a vanilla progress bar for file downloads that simply shows how much of the file has been downloaded so far. A new FileDownloadProgressBar widget replaces the existing animated spinner, and we inject a signal through to the SDK to pass the current progress back to the widget. The widget both displays the overall total progress as a percentage and also calculates the download speed by using an exponential moving average to smooth it out. A timer runs every 100ms to recalculate the speed. A new utils.humanize_speed() is used to translate the raw bytes/second into a human-readable version with a focus on keeping the length of the string roughly consistent so there's less visual shifting. Once the download has finished, an indeterminate progress bar is shown while decrypting since we don't (currently) have a way to report specific progress on that. TODO: * tests? Fixes #1104.
legoktm
force-pushed
the
download-progress
branch
from
6ae75e9 to
0eb51f6
Compare
Status
Work in progress
TODO:
Description
Display a vanilla progress bar for file downloads that simply shows how much of the file has been downloaded so far.
A new FileDownloadProgressBar widget replaces the existing animated spinner, and we inject a signal through to the SDK to pass the current progress back to the widget.
Fixes #1104.
Test Plan
NUM_SOURCES=10 --random-file-size 100000to generate 10 sources with 100MB attachmentsChecklist